Repository navigation
fix(content): drop the circle, add a speed guard to before takeoff - #43
Merged
Merged
Conversation
A show_rule that was already true when the pilot reached the idle hub (e.g. a stand inside the Before Takeoff zone) sent them straight into the procedure the moment Before Taxi finished. The poll now returns new_show_procedures (the False -> True subset) and only those slugs auto-navigate; a rule already true stays a suggestion. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KAKXdsiZ923UK4EmHj25EM
This reverts commit 02617d1.
Before Takeoff opened as soon as Before Taxi finished because a stand close to the runway sat inside the 500 m near circle. Only the corridor over the runway remains as the position test, and groundspeed < 5 m/s (about 10 kt) is required. B738 content 1.4.1 -> 1.4.2. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KAKXdsiZ923UK4EmHj25EM
chezhj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before Takeoff opened as soon as Before Taxi finished. Session 129 showed the gate move to Before Takeoff 0.5 s after the last Before Taxi item was ticked: its
show_rulewas already true from the stand. The rule was a 500 mnearcircle around the runway threshold or the runway corridor, plusy_agl < 5, with no speed check. A stand near the runway sits inside the circle.nearcircle; the corridor over the runway (150 m behind the threshold, 4000 m ahead, 90 m either side) is the only position test.sim/flightmodel/position/groundspeed < 5(m/s, about 10 kt), so the procedure opens once the aircraft has slowed to line up or hold, not while it taxis through the corridor.content_version1.4.1 to 1.4.2 (scripts/check_content_bump.pypasses).docs/CORRIDOR_OPERATOR_SPEC.md.The branch also carries a rising-edge auto-navigation change and its revert, which cancel out. The net diff is the two files above.
Test plan
pytest checklist/tests/test_rules.py checklist/tests/test_content_command.pypasstestandpr-titlegreensim/flightmodel/position/groundspeed(no existing rule uses it) or loosen the 5 m/s limit.The full suite was last run before the final change; CI will run it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KAKXdsiZ923UK4EmHj25EM