WebUiScreen: Close modals with back button#160
Merged
Conversation
chenxiaolong
force-pushed
the
web-ui-back
branch
2 times, most recently
from
e1f357a to
9d32237
Compare
The behavior is now more in line with how native dialogs work when pressing the back button. Nested modals are supported and each back invocation will only close the topmost one. After all modals are closed, it falls back to the previous behavior of going to the previous WebView history page or finishing the Activity if there is no history left. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
web-ui-back
branch
from
9d32237 to
61861db
Compare
chenxiaolong
added a commit
that referenced
this pull request
Jun 14, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior is now more in line with how native dialogs work when pressing the back button. Nested modals are supported and each back invocation will only close the topmost one. After all modals are closed, it falls back to the previous behavior of going to the previous
WebViewhistory page or finishing theActivityif there is no history left.