Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ocavue
left a comment
There was a problem hiding this comment.
LGTM. I left a small comment about the package.json, but that's not a deal breaker.
what those fields would be? |
|
|
|
I don't think those would hurt - so if we could have the |
|
Those are not in the main repo. It's only added here because this repo dual-publish. I imagine if we migrate this package as ESM-only it won't emit those fields. I personally prefer the stricter exports the package has now though. |
|
Let's followup with making this ESM-only soon then |
|
Thanks. Don't know why I just deleted that 😅 |
Copied the config from core, except
exports: falsesince it adds additional fields that I don't think we want.