Skip to content

Migrate to tsdown#63

Merged
bluwy merged 5 commits into
mainfrom
tsdown
May 19, 2026
Merged

Migrate to tsdown#63
bluwy merged 5 commits into
mainfrom
tsdown

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented May 18, 2026

Copied the config from core, except exports: false since it adds additional fields that I don't think we want.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 18, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpublint@​0.3.201001008189100
Addedtsdown@​0.22.0981008896100

View full report

Comment thread package.json
Copy link
Copy Markdown
Contributor

@ocavue ocavue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a small comment about the package.json, but that's not a deal breaker.

@Andarist
Copy link
Copy Markdown
Member

except exports: false since it adds additional fields that I don't think we want.

what those fields would be?

@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented May 18, 2026

main, module, types, exports["./package.json"]

@Andarist
Copy link
Copy Markdown
Member

I don't think those would hurt - so if we could have the exports and other fields auto-generated then that's what I would prefer. Like, if those are good/OK for us in the main repo - why we'd diverge here?

@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented May 18, 2026

Those are not in the main repo. It's only added here because this repo dual-publish. I imagine if we migrate this package as ESM-only it won't emit those fields.

I personally prefer the stricter exports the package has now though.

@Andarist
Copy link
Copy Markdown
Member

Let's followup with making this ESM-only soon then

Andarist
Andarist previously approved these changes May 18, 2026
@bluwy bluwy enabled auto-merge May 18, 2026 17:24
@bluwy bluwy requested a review from Andarist May 18, 2026 17:25
Comment thread pnpm-workspace.yaml
@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented May 19, 2026

Thanks. Don't know why I just deleted that 😅

@bluwy bluwy added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 97cec67 May 19, 2026
9 checks passed
@bluwy bluwy deleted the tsdown branch May 19, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants