Add packages to pnpm-workspace.yaml to include root package#113
Conversation
|
@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel. A member of the Team first needs to authorize it. |
da4fef2 to
ffc5b8f
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ec44c8b to
9e109a8
Compare
|
Hm, the preview deployment got built but something looks off cause I see this in the logs: I'm not sure if this is a new issue or if that was present with Yarn |
| "rewriteRelativeImportExtensions": true, | ||
| "skipLibCheck": true, | ||
| "lib": ["esnext"], | ||
| "types": ["node"], |
There was a problem hiding this comment.
get-changed-packages.ts(67,16): error TS2339: Property 'json' does not exist on type 'Response'.
get-changed-packages.ts(78,16): error TS2339: Property 'text' does not exist on type 'Response'.
Those lines make me think there’s a mismatch in the loaded types.
Hopefully, explicitly adding them to the tsconfig will solve the issue.
The errors in index seem to come from probot’s types, which also rely on @types/node, so hopefully those are fixed as well now.
|
I still see those in the logs: I'll investigate this further tomorrow unless you know what the fix for this should be |
|
It still errors with the same type errors but I have found the culprit: vercel/vercel#16370 I think it's fine to ship this because it shouldn't quite affect the deployed code. We should replace the implicit build script with rolldown, like here: changesets/action#621 . We gotta be careful about aligning the output |
pnpm#112 (comment)I updated the
"packageManager": "yarn@1.22.22"
packageManagerfield, removing the hash to keep the same format that was previously used withyarn.bot/package.json
Line 49 in af23c7e
Not needed, adding repo root to
pnpm-workspace.yaml#packagessolved the issuepackages field missing or empty, I added apackagesentry pointing to the repository root inpnpm-workspace.yaml.Additional changes to try if the deployment still fails
ENABLE_EXPERIMENTAL_COREPACK=1Reference: https://vercel.com/docs/builds/configure-a-build#corepack