Repository navigation
Conversation
… the certificates of their own session The access control added for BT#23524 only grants access to the owner, a platform admin or a teacher of the certificate's course (CourseManager::is_course_teacher). In a session the tutors are session coaches (status 2 in session_rel_course_rel_user) and the general coach, not teachers of the base course, and session admins are not course teachers either, so they get "not allowed" when opening a certificate from the session gradebook, even though they can list it. Grant access to those roles, restricted to the session the certificate belongs to: - course coach of that course in that session (api_is_course_session_coach) - general coach of that session (SessionManager::user_is_general_coach) - session admin, if the platform lets session admins manage all sessions or if they are the admin of that session (session_admin_id) Students, coaches of other sessions and anonymous visitors keep the same behaviour. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the certificates of their own session
The access control added for BT#23524 only grants access to the owner, a platform admin or a teacher of the certificate's course (CourseManager::is_course_teacher). In a session the tutors are session coaches (status 2 in session_rel_course_rel_user) and the general coach, not teachers of the base course, and session admins are not course teachers either, so they get "not allowed" when opening a certificate from the session gradebook, even though they can list it.
Grant access to those roles, restricted to the session the certificate belongs to:
Students, coaches of other sessions and anonymous visitors keep the same behaviour.