Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9339 +/- ##
============================================
+ Coverage 19.12% 19.17% +0.05%
- Complexity 63847 63909 +62
============================================
Files 2591 2592 +1
Lines 238077 238222 +145
============================================
+ Hits 45523 45672 +149
+ Misses 192554 192550 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6 of 21 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of #9337: the course-event features the legacy agenda still had are now in the Vue agenda, and the legacy agenda page redirects to it.
Changes
resource_links.user, so a course event sent to one user (for example, one created with the legacyagenda.php) was visible to the whole course, and the personal agenda listed events sent to other users and to other groups. A learner now sees the events of the whole course, of their groups, and the events sent to them, as inAgenda::getCourseEvents(). Teachers see all of them. Outside a group,GroupContextQueryExtensionno longer hides the events of the learner's groups (only forCCalendarEvent).AgendaHelper::canAddLinks()rejects auidthat is not subscribed to the course (or to the course in the session) and agidof another course.GET /api/calendar/course-recipientsendpoint (teachers only).courseRecipientsin the PUT replaces the links of the event in the current course.ResourceListenerkeeps thegidof a single-link calendar event outside a group context; the CREATE voter validates it first.recipient=USER:<id>|GROUP:<id>lists the events sent to one user or group. It only has an effect for course editors. The selector is shown in the month view and in the list view.calendar/agenda_js.phpredirects bytype(admin/platform→?type=global).my_space/calendar_plan.php, which was already broken on master, redirects to the personal agenda, and its links were removed.inc/ajax/agenda.ajax.phpandagenda/month.html.twigwere deleted (both are inUPDATE-METADATA.json).Tests
tests/CoreBundle/Api/CCalendarEventRecipientApiTest.php: 11 tests covering visibility per role, recipient validation, editing recipients, the filter and the recipient endpoint. The visibility and validation tests fail without the fix.calendarCourseRecipients.feature(new) andagendaLegacyRedirects.feature(extended).3.x/en/teacher-guide/additional-tools/agenda.mdin the docs repository (allbranch).Out of scope
CCalendarEventVoterlets only the creator edit an event, so another teacher of the course cannot edit it.allow_user_edit_agendacan send links withuid/gidthrough the API. The legacy form did not show the selector to learners.🤖 Generated with Claude Code