Fix default bitmap font measurements - #18
Open
aardvarkk wants to merge 1 commit into
Open
Conversation
Initialize BGI text at the RIPscrip normal default size so bitmap text is measured at the same scale it is drawn. Add a visual button fixture and expected rendering covering implicit versus explicit size-one text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This change was AI-assisted!
Summary
I ran into issues when looking at some of the RIP renderings from LORD. Many buttons were correct, but a bunch had uncentered text. The fix here is to initialize BGI text at the RIPscrip normal default size of 1 (instead of the current value of 0) so bitmap text is measured at the same scale it is drawn. Add a visual button fixture and expected rendering covering implicit versus explicit size-one text.
Before
After