Skip to content

Added mpf_masterfiles_stage_run_always class to enable legacy behavior of masterfiles-stage to always run cfbs build#6109

Merged
nickanderson merged 1 commit intocfengine:masterfrom
craigcomstock:ent-13756/master
May 4, 2026
Merged

Added mpf_masterfiles_stage_run_always class to enable legacy behavior of masterfiles-stage to always run cfbs build#6109
nickanderson merged 1 commit intocfengine:masterfrom
craigcomstock:ent-13756/master

Conversation

@craigcomstock
Copy link
Copy Markdown
Contributor

This enables the previous unwanted behavior of running cfbs regardless of whether changes exist.
In some cases this behavior was used to run scripts which updated information dynamically on a periodic basis.
The goal of cfbs is to make reproducible builds so this strategy is not recommended and the behavior in masterfiles-stage is deprecated.

Ticket: ENT-13756
Changelog: title

Copy link
Copy Markdown
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should this be elevated to the README?

…ehavior of masterfiles-stage to always run cfbs build

This enables the previous unwanted behavior of running cfbs regardless of whether changes exist.
In some cases this behavior was used to run scripts which updated information dynamically on a periodic basis.
The goal of cfbs is to make reproducible builds so this strategy is not recommended and the behavior in masterfiles-stage is deprecated.

Ticket: ENT-13756
Changelog: title
@craigcomstock
Copy link
Copy Markdown
Contributor Author

Makes sense. Should this be elevated to the README?

yes, already done, was very draft when you reviewed :)

@craigcomstock craigcomstock marked this pull request as ready for review May 4, 2026 21:41
@nickanderson nickanderson merged commit 8f16b05 into cfengine:master May 4, 2026
11 checks passed
@craigcomstock craigcomstock added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 4, 2026
@craigcomstock craigcomstock deleted the ent-13756/master branch May 4, 2026 22:53
@craigcomstock
Copy link
Copy Markdown
Contributor Author

cherry picks: #6111 and #6112

@craigcomstock craigcomstock removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants