Conversation
Evan-Adam
force-pushed
the
CTOR-2209-catcher-les-panic-pour-toujours-envoyer-un-statut-unknown-et-une-output-le-plus-parlant-possible-la-ou-on-a-des-unwrap
branch
from
July 28, 2026 11:24
1aacdcb to
f751344
Compare
CTOR-2209
Evan-Adam
force-pushed
the
CTOR-2209-catcher-les-panic-pour-toujours-envoyer-un-statut-unknown-et-une-output-le-plus-parlant-possible-la-ou-on-a-des-unwrap
branch
from
July 28, 2026 11:24
f751344 to
6d2112b
Compare
Evan-Adam
marked this pull request as ready for review
July 28, 2026 13:01
omercier
approved these changes
Jul 28, 2026
omercier
deleted the
CTOR-2209-catcher-les-panic-pour-toujours-envoyer-un-statut-unknown-et-une-output-le-plus-parlant-possible-la-ou-on-a-des-unwrap
branch
July 28, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr add a panic catcher and replace some (not all) of the unwrap to proper
Resulterror.Fixes # CTOR-2209
Type of change
How this pull request can be tested ?
See automated tests for the case "no host answer our query", some other error (like not being able to bind a local port) are harder to test
Checklist