Repository navigation
Conversation
…d dcm4che) and utility detection rules for tls Signed-off-by: Fynn Thierling <fynnth@outlook.de>
Signed-off-by: Fynn Thierling <fynnth@outlook.de>
Signed-off-by: Fynn Thierling <fynnth@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport security and DICOM for C# and Java
This adds detection rules mainly for csharp and a few for java.
What's in it
OpenSSL via P/Invoke : the bulk of the work. Ciphers with their mode and key length
(
AES-256-GCM,DESede168-CBC), digests, MACs, key generation (RSA-4096,DSA-2048,named curves from numeric NIDs), KDFs with their iteration counts, RNG, and the TLS side:
protocol versions from both
*_method()andset_min/max_proto_version, plus cipher listsresolved to IANA suite names.
.NET TLS :
SslStream's handshake methods, the protocol properties on the variousoptions objects, Kestrel's
UseHttps, the legacyServicePointManagerswitch, andCipherSuitesPolicy, which expands into the algorithms behind each suite.Schannel : direct SSPI P/Invoke. Protocol versions and the security package name only:
the modern credential structure carries deny-lists rather than anything a caller requests,
and a disabled algorithm is not an algorithm in use.
DICOM: fo-dicom on the C# side (client and server) and dcm4che on the Java side,
including whether the association is TLS-protected and which versions it offers. Details are not always possible in which case it just reports dicom with or wothout TLS (not reporting exact versions).
Java SSL : a few gaps closed around
SSLParametersendpoints and enabled settings.Alongside that, some engine fixes the rules needed: array initializers and their elements
were invisible to the C# engine, hex literals were classified as strings, and a flags
combination (
Tls12 | Tls13) inferred asintrather than as the enum it is.Notes for review
their licence. If the download fails or is unavailable, those tests skip and the build
still passes.