This repository was archived by the owner on Oct 28, 2021. It is now read-only.
TypeScript/Rollup Rewrite#18
Open
todd-elvers wants to merge 15 commits into
Open
Conversation
added 9 commits
May 29, 2021 10:33
Rewrote application in TypeScript Rewrote Storybook config in TypeScript Added Storybook controls and more stories Changed bundler from babel to rollup Added ESM support Integrated parse-unit library directly into app Added jest, ts-jest, and associated config for running tests Updated react-lottie-player Added commit hook for prettier so changed files are always formatted Added commit hook to type-check app before allowing commits
Contributor
Author
|
Okay, I believe I'm done with my changes. Recent:
I'll be around this weekend if you have questions about any of these changes. |
Contributor
Author
|
I've moved That's my final change, I swear 😄 Could someone create a canary/dev release so I can test? |
Contributor
Author
|
@cawfree Any chance you could take a look at this? I can rebase if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript/Rollup Rewrite
animationData.jsondirectly into the codeparse-unitdirectly into the libraryjest,ts-jest, and associated configuration for running tests withyarn testreact-lottie-playerto the latest versionprettierbefore committingREADME.mdyarn.lockfrom.gitignoreand committed it.storybookand.babelrcto.npmignore1.0.0react-lottie-playertopeerDependenciesreactandreact-domtopeerDependencies