Skip to content

CORE-245#5417

Open
EdHastingsCasperAssociation wants to merge 3 commits into
casper-network:devfrom
EdHastingsCasperAssociation:core-245-system-purse
Open

CORE-245#5417
EdHastingsCasperAssociation wants to merge 3 commits into
casper-network:devfrom
EdHastingsCasperAssociation:core-245-system-purse

Conversation

@EdHastingsCasperAssociation

Copy link
Copy Markdown
Collaborator

This PR removes add / write from system purse. Incidentally, also cleaned up some comments and removed some redundancies.

@zajko zajko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question

AccountRepr::Account(account) => account,
AccountRepr::EntityAddr(_) => {
// account has been upgraded to addressable entity, so get out
return Ok(());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be concerned with the possibility that someone currently operates a private chain with ae turned on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants