Various friedland fix#927
Open
henrydingliu wants to merge 10 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 88 88
Lines 5029 5029
Branches 642 642
=======================================
Hits 4440 4440
Misses 444 444
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
closes #926
closes #925
closes #924
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Changes are limited to bundled sample CSVs,
_manifest.pymetadata, and Friedland documentation doctests; no runtime estimation or core triangle logic is modified.Overview
This PR enriches bundled Friedland sample data and simplifies how Chapter 6 loads triangles, without changing library APIs.
friedland_xyz_auto_biis expanded in_manifest.pyand its CSV so one sample carries paid/reported losses plus claim counts, case outstanding, and reported severities. The separatefriedland_xyz_caseandfriedland_xyz_freq_seventries and CSVs are removed; that data now lives only on the consolidatedfriedland_xyz_auto_bisample.friedland_auto_freq_sevgains a Paid Claims column (mostly populated on latest development rows).friedland_wc_self_insurergains Payroll on calendar-year rows, supporting chapter 11-style examples.docs/friedland/chapter_6.rstdoctests no longer loadfriedland_xyz_freq_sevfor count/severity tables; they slice the sametrifromfriedland_xyz_auto_bifor reported/closed counts and severity/case-outstanding calculations.Reviewed by Cursor Bugbot for commit cc4756f. Bugbot is set up for automated code reviews on this repo. Configure here.