Repository navigation
[BUG] dev_to_val, val_to_dev, and _val_dev inplace argument not working #1477
Copy link
Copy link
Labels
Great First Contribution! 🌱Beginner friendly tickets with narrow scope and huge impact. Perfect to get your feet wet!Beginner friendly tickets with narrow scope and huge impact. Perfect to get your feet wet!
Milestone
Description
Are you on the latest chainladder version?
- Yes, this bug occurs on the latest version.
Describe the bug in words
the two val methods and their private helper always return a new object
How can the bug be reproduced?
_ = raa.dev_to_val(True)
print(raa) 12 24 36 48 60 72 84 96 108 120
1981 5012.0 8269.0 10907.0 11805.0 13539.0 16181.0 18009.0 18608.0 18662.0 18834.0
1982 106.0 4285.0 5396.0 10666.0 13782.0 15599.0 15496.0 16169.0 16704.0 NaN
1983 3410.0 8992.0 13873.0 16141.0 18735.0 22214.0 22863.0 23466.0 NaN NaN
1984 5655.0 11555.0 15766.0 21266.0 23425.0 26083.0 27067.0 NaN NaN NaN
1985 1092.0 9565.0 15836.0 22169.0 25955.0 26180.0 NaN NaN NaN NaN
1986 1513.0 6445.0 11702.0 12935.0 15852.0 NaN NaN NaN NaN NaN
1987 557.0 4020.0 10946.0 12314.0 NaN NaN NaN NaN NaN NaN
1988 1351.0 6947.0 13112.0 NaN NaN NaN NaN NaN NaN NaN
1989 3133.0 5395.0 NaN NaN NaN NaN NaN NaN NaN NaN
1990 2063.0 NaN NaN NaN NaN NaN NaN NaN NaN NaNWhat is the expected behavior?
1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
1981 5012.0 8269.0 10907.0 11805.0 13539.0 16181.0 18009.0 18608.0 18662.0 18834.0
1982 NaN 106.0 4285.0 5396.0 10666.0 13782.0 15599.0 15496.0 16169.0 16704.0
1983 NaN NaN 3410.0 8992.0 13873.0 16141.0 18735.0 22214.0 22863.0 23466.0
1984 NaN NaN NaN 5655.0 11555.0 15766.0 21266.0 23425.0 26083.0 27067.0
1985 NaN NaN NaN NaN 1092.0 9565.0 15836.0 22169.0 25955.0 26180.0
1986 NaN NaN NaN NaN NaN 1513.0 6445.0 11702.0 12935.0 15852.0
1987 NaN NaN NaN NaN NaN NaN 557.0 4020.0 10946.0 12314.0
1988 NaN NaN NaN NaN NaN NaN NaN 1351.0 6947.0 13112.0
1989 NaN NaN NaN NaN NaN NaN NaN NaN 3133.0 5395.0
1990 NaN NaN NaN NaN NaN NaN NaN NaN NaN 2063.0Would you be willing to contribute this ticket?
- Yes, absolutely!
- Yes, but I would like some help.
- No.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Great First Contribution! 🌱Beginner friendly tickets with narrow scope and huge impact. Perfect to get your feet wet!Beginner friendly tickets with narrow scope and huge impact. Perfect to get your feet wet!
Type
Fields
Priority
Urgent
Effort
Low
Scope
Codebase
Projects
- StatusShow more project fieldsNot Ready
Activity
henrydingliu commentedon Oct 9, 2026
we can safely assume no user is currently using inplace=True on these methods. along with the bug fix, please return None when inplace=True
henrydingliu commentedon Oct 10, 2026
blocked by #1481
henrydingliu commentedon Oct 11, 2026
refactored a bit further. no longer blocked by #1481. pr ready soon