Repository navigation
Create ULT_DEV property on Options #1049
Description
Activity
there's a few 9999 to clean up, in addition to a couple places where ult_dev should be used instead of ult_val.
we should also add a test or two to check for consistency of assigning ult_val
I can take this on, will add options.ULT_DEV, clean up the hardcoded 9999s, and add consistency unit tests.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Priority
Medium
Effort
Medium
Scope
Codebase
Description
Arose out of #1022. We can move the following 9999 ultimate placeholder development value in to the package options.
self.disposal_ = concat((self.disposal_,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)Is your feature request aligned with the scope of the package?
Describe the solution you'd like, or your current workaround.
Something like
Do you have any additional supporting notes?
This should be derived from
options.ULT_VALand thus be defined as a property. It might not be exactly 9999, it's whatever the monthly equivalent would be.Would you be willing to contribute this ticket?