Update urlify.js#22
Open
annamatveev wants to merge 1 commit intocareercup:masterfrom
Open
Conversation
profnandaa
reviewed
Oct 2, 2018
Collaborator
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Thanks too for your PR here. I'm going to check in context then merge.
| var urlify = function(str, length) { | ||
| // have a pointer to check from start to end | ||
| var strArr = str.split(''); | ||
| var strArr = str.trim().split(''); |
Collaborator
There was a problem hiding this comment.
Does this fix the comments in line 7? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding trim to remove spaces in the beginning or the end of the string.