feat: support geohash prefix matching for #g filters#586
Open
kanishka0411 wants to merge 1 commit intocameri:mainfrom
Open
feat: support geohash prefix matching for #g filters#586kanishka0411 wants to merge 1 commit intocameri:mainfrom
kanishka0411 wants to merge 1 commit intocameri:mainfrom
Conversation
Collaborator
2846cd8 to
b10b02b
Compare
🦋 Changeset detectedLatest commit: b10b02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for geohash prefix matching for
#gfilters.A query like
{ "#g": ["u4pruyd*"] }now matches events with geohash tags starting withu4pruyd, for example["g", "u4pruydqqvj"].Exact
#gfilters without*still behave the same as before, sou4pruyddoes not matchu4pruydqqvj.Related Issue
Fixes #265
Motivation and Context
Geohash searches usually work with prefixes, especially when a client is looking for events inside a map area.
Before this, Nostream treated
#glike any other generic tag filter and only did exact matching. That meant the wildcard form requested in #265, likeu4pruyd*, did not match longer geohash values.This updates both paths that need the behavior:
LIKE 'prefix%'startsWithSo historical results and live events stay consistent.
How Has This Been Tested?
Added unit tests for:
#gmatching without wildcardLIKE 'prefix%'vs=)All passing locally.
Screenshots (if appropriate):
Types of changes
Checklist: