Skip to content

Fix trading sheet tab bar spacing#173

Merged
V3RON merged 2 commits into
super-app-showcase-refreshfrom
dannyhw/fix-trade-sheet-keyboard-padding
Jul 7, 2026
Merged

Fix trading sheet tab bar spacing#173
V3RON merged 2 commits into
super-app-showcase-refreshfrom
dannyhw/fix-trade-sheet-keyboard-padding

Conversation

@dannyhw

@dannyhw dannyhw commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes spacing for the trading flow around the native bottom tab bar.

The trade bottom sheet now receives the tab bar inset from the asset details screen and uses it as bottom content padding, so the sheet content stays clear of the tabs while the sheet can still present from the bottom. The trade button footer also keeps compact Android padding while preserving iOS tab bar clearance.

The iOS tab bar height can briefly report as zero on initial render, so the details screen uses a standard tab bar height plus safe-area inset as a fallback.

Test plan

  • Open an asset details screen on iOS and tap Trade. Confirm the bottom sheet actions are not covered by the tab bar.
  • Focus the amount input on iOS. Confirm the sheet works with the keyboard open and with keyboard closed
  • Open an asset details screen on Android. Confirm the sheet works with the keyboard open and with keyboard closed
image image

@dannyhw dannyhw marked this pull request as ready for review July 1, 2026 22:19
@V3RON V3RON merged commit 89f8ebe into super-app-showcase-refresh Jul 7, 2026
@V3RON V3RON deleted the dannyhw/fix-trade-sheet-keyboard-padding branch July 7, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants