Repository navigation
Conversation
ziarno
reviewed
Oct 16, 2026
| it('moves focus when opened and restores it when closed', async () => { | ||
| const { rerender } = await render(makeMenu(false)); | ||
| await rerender(makeMenu(true)); | ||
| await act(() => jest.advanceTimersByTime(300)); |
There was a problem hiding this comment.
nit: instead of using a magic number 300, I'd create a constant like:
const PAST_ANIMATION_MS = 300;
this explains the value
Author
There was a problem hiding this comment.
Addressed in b04739b: all four web-focus timer advances now use PAST_ANIMATION_MS = 300.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closed menus steal focus on mount and scroll async lists. Initialize previous visibility from
visible, preserving focus on open/close.Related issue
Closes #4907
Screenshots / Videos
Append 30 closed menus: before, focus moves to Menu 29 and scroll reaches 1620px; after, focus stays on the append button and scroll stays at 0.
Test plan
Append closed menus: focus/scroll stay put. Open: first item focuses. Escape: anchor focuses. Chrome checked.
695 tests and 234 snapshots pass; lint/typecheck pass. Hidden-mount regression fails before the fix.
Repro and DOM checks