Skip to content

fix(ios): guard pager callbacks without a Fabric emitter #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

fix(ios): guard pager callbacks without a Fabric emitter #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ios/RNCPagerViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,22 @@ - (void)updateProps:(const facebook::react::Props::Shared &)props oldProps:(cons
#pragma mark - PagerViewProviderDelegate

- (void)onPageScrollWithData:(OnPageScrollEventData *)data {
const auto eventEmitter = [self pagerEventEmitter];
[self sendScrollEventsForPosition:data.position offset:data.offset];
}

- (void)onPageSelectedWithPosition:(NSInteger)position {
const auto eventEmitter = [self pagerEventEmitter];
if (!eventEmitter) {
return;
}
eventEmitter->onPageSelected(RNCViewPagerEventEmitter::OnPageSelected{.position = static_cast<double>(position)});
}

- (void)onPageScrollStateChangedWithState:(enum PageScrollState)state {
const auto eventEmitter = [self pagerEventEmitter];
if (!eventEmitter) {
return;
}

RNCViewPagerEventEmitter::OnPageScrollStateChangedPageScrollState scrollState;

Expand Down Expand Up @@ -171,6 +176,9 @@ - (void)setScrollEnabledImperatively:(BOOL)scrollEnabled {

- (void)sendScrollEventsForPosition:(NSInteger)position offset:(CGFloat)offset {
const auto eventEmitter = [self pagerEventEmitter];
if (!eventEmitter) {
return;
}
eventEmitter->onPageScroll(RNCViewPagerEventEmitter::OnPageScroll{
.position = static_cast<double>(position),
.offset = offset
Expand Down