Skip to content

fix(ios): detach hosting controllers when the pager loses its parent #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

fix(ios): detach hosting controllers when the pager loses its parent #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ios/PagerViewProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,19 @@ import UIKit
/// preserving the view itself. Keep the hosting controller attached to the
/// current page controller so UIKit's view-controller hierarchy stays valid.
private func syncParentViewController(to parentViewController: UIViewController? = nil) {
guard let hostingController,
let parentViewController = parentViewController ?? reactViewController(),
hostingController.parent !== parentViewController else {
guard let hostingController else {
return
}
let parentViewController = parentViewController ?? reactViewController()
guard hostingController.parent !== parentViewController else {
return
}

hostingController.willMove(toParent: nil)
hostingController.removeFromParent()
parentViewController.addChild(hostingController)
hostingController.didMove(toParent: parentViewController)
if let parentViewController {
parentViewController.addChild(hostingController)
hostingController.didMove(toParent: parentViewController)
}
}
}