Skip to content

perf: initialize pager hook resources once #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −8
Open

perf: initialize pager hook resources once #1124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/usePagerView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function usePagerView(
{ pagesAmount }: UsePagerViewParams = { pagesAmount: 0 }
) {
const ref = useRef<PagerView>(null);
const [pages, setPages] = useState<number[]>(
const [pages, setPages] = useState<number[]>(() =>
new Array(pagesAmount).fill('').map((_v, index) => index)
);
const [activePage, setActivePage] = useState(0);
Expand All @@ -36,9 +36,9 @@ export function usePagerView(
const [scrollEnabled, setScrollEnabled] = useState(true);
const [scrollState, setScrollState] = useState('idle');
const [progress, setProgress] = useState({ position: 0, offset: 0 });
const onPageScrollOffset = useRef(new Animated.Value(0)).current;
const onPageScrollPosition = useRef(new Animated.Value(0)).current;
const onPageSelectedPosition = useRef(new Animated.Value(0)).current;
const [onPageScrollOffset] = useState(() => new Animated.Value(0));
const [onPageScrollPosition] = useState(() => new Animated.Value(0));
const [onPageSelectedPosition] = useState(() => new Animated.Value(0));

const setPage = useCallback(
(page: number) =>
Expand Down Expand Up @@ -99,8 +99,7 @@ export function usePagerView(
useNativeDriver: true,
}
),
// eslint-disable-next-line react-hooks/exhaustive-deps
[]
[onPageScrollOffset, onPageScrollPosition]
);

const onPageSelected = useMemo(
Expand All @@ -114,8 +113,7 @@ export function usePagerView(
useNativeDriver: true,
}
),
// eslint-disable-next-line react-hooks/exhaustive-deps
[]
[onPageSelectedPosition]
);

const onPageScrollStateChanged = useCallback(
Expand Down