Repository navigation
docs(plugins): document plugin contract v2, the inventory and ADR 0034 - #3769
Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
There was a problem hiding this comment.
All reported issues were addressed across 6 files
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
190029c to
296826f
Compare
296826f to
058826d
Compare
|
This PR is ready at 058826d. CI is green, with 14 checks and none failing, and the change is docs-only. No conflicts. Not blocking, take or leave: the Connect section at website/docs/docs/plugins.md#L95 lists |
058826d to
5c46bf5
Compare
|
Thanks. Taken in 5c46bf5: the Connect example now passes |
5c46bf5 to
f93a0a0
Compare
|
The PR is ready. At f93a0a0 the docs match the contract and inventory types they describe, and CI is green with 14 checks and none failing. I found no conflicts. Nothing is left to do before merge. I only checked the contract and inventory types the docs describe. I did not read ADR 0034 in full (I only grepped it for status and fingerprint claims), and I did not trace the daemon status CLI rendering. The stacked code under the docs (daemon registration and registry) is also outside what I read. Not blocking, take or leave: website/docs/docs/plugins.md:39 says |
f93a0a0 to
51dc157
Compare
51dc157 to
fc0516a
Compare
fc0516a to
289bc66
Compare
289bc66 to
2d8cb1a
Compare
|
Rebased onto the new #3768. Docs and ADR 0034 now describe |
c4ac622 to
22f4e58
Compare
|
The PR is ready. At c4ac622 the docs match the code they describe, and no code changes are needed. Not blocking, and you can take or leave these: the two docs sentences that say only a missing daemon.json means stopped could say that a missing or stale record means stopped, and that an unreadable or invalid file never does. The CHANGELOG entry could also describe the embedder source as the contract's third slot, coming in #3757, since the only composition at this head uses built-in and store candidates. The earlier clean review was at fc0516a (#3769 (comment)). This head is that work rebased onto #3768. I read the docs files and the code they describe, and did not run the docs build, link checks, or tests. The only check still pending is Smoke Tests, which is queued and has not run. This PR changes docs only, so it cannot affect a smoke route. Smoke Tests must finish green before merge. There are no conflicts. This review covers c4ac622. The newer head 22f4e58 is the same two commits rebased onto bddb30f, with no content change. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ecisely Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The PR is ready at 22f4e58. The earlier clean review of fc0516a still holds, and the 8 threads that were open then are now resolved. The checks are green (19 checks, 0 not passing, docs-only diff) and there are no conflicts. Not blocking: the line "Only an absent file means stopped" in website/docs/docs/plugins.md is too narrow, because daemon-registration.ts:146-162 also reports stopped for a record with a null or dead pid, and the ADR 0034 rule "only absent reads as a stopped daemon" has the same gap. You could say that a missing or stale record means stopped, and that an unreadable or invalid file never does. Take it or leave it. I checked the status state machine and the inventory type, but not how the CLI renders daemon status output. The CHANGELOG sentence that calls the embedder a source depends on #3757, and I did not check that the source is wired at the base. I also did not re-check each resolved thread against its fix. Nothing else stands in the way, so merge once the base PR in the stack lands. |
22f4e58 to
224b819
Compare
|
Pushed |
|
The PR is ready. At 224b819 the docs match the code, and the earlier review is still the state of the PR. CI is green with 19 checks and none failing, and the diff is docs only, so no production code changes. There are no conflicts. Not blocking, and you can take it or leave it: website/docs/docs/plugins.md:37 says |
…ment * origin/main: feat(provider-testmu): publish @agent-device/testmu on plugin contract v2 (#3770) docs(plugins): document plugin contract v2, the inventory and ADR 0034 (#3769) feat(daemon): daemon status lists the registered provider plugins (#3768) feat(plugins): plugin contract v2 and one provider registry (#3767) # Conflicts: # packages/daemon/src/sessions/handlers/lease.ts # src/__tests__/cloud-connect-testmu.test.ts # src/cli/commands/connection.ts # src/cli/commands/daemon.ts # src/daemon-client/daemon-client-metadata.ts # src/daemon-client/daemon-client.ts
…-no-process-globals * refactor/host-environment: feat(provider-testmu): publish @agent-device/testmu on plugin contract v2 (#3770) docs(plugins): document plugin contract v2, the inventory and ADR 0034 (#3769) feat(daemon): daemon status lists the registered provider plugins (#3768) feat(plugins): plugin contract v2 and one provider registry (#3767) # Conflicts: # packages/daemon/src/server/http/daemon-runtime-composition.test.ts # packages/daemon/src/server/http/daemon-runtime-metadata-ownership.test.ts # packages/daemon/src/server/http/daemon-runtime.ts # src/daemon-composition.ts
Summary
Part 3 of 4 of #3755 (umbrella #3747), stacked on #3768. Blocked by #3748: do not merge before it.
Docs only:
website/docs/docs/plugins.md: v2 authoring (./agent-deviceexport, factory with options,setup, credentials withbyBackend,connection), entry discovery and the no-fallback rule, the registry order and duplicate rule,daemon statusand the inventory entry shape, and a short section on v1 plugins.docs/adr/README.md.CHANGELOG.mdentry for the contract, registry, isolation, inventory anddaemon status.limrun.mdandbuild-an-integration.mdfollow the renamed diagnostic and contract.Runtime tests do not apply to prose; the docs checks in
check:affectedran.Validation
pnpm check:affected --run --head a304bb7f40(the stack top, which contains this layer): passed (exactCommit).🤖 Generated with Claude Code