test: move root src tests off the daemon's testing exports

packages/daemon/package.json

@@ -48,10 +48,6 @@
       "types": "./src/core/__tests__/capture-disclosure-target-activation-fact.ts",
       "default": "./src/core/__tests__/capture-disclosure-target-activation-fact.ts"
     },
-    "./testing/__tests__/human-control-fixtures": {
-      "types": "./src/__tests__/support/human-control-fixtures.ts",
-      "default": "./src/__tests__/support/human-control-fixtures.ts"
-    },
     "./testing/__tests__/interaction-get-runtime-fixture": {
       "types": "./src/execution/__tests__/interaction-get-runtime-fixture.ts",
       "default": "./src/execution/__tests__/interaction-get-runtime-fixture.ts"
@@ -60,10 +56,6 @@
       "types": "./src/__tests__/support/legacy-snapshot-capture-fixture.ts",
       "default": "./src/__tests__/support/legacy-snapshot-capture-fixture.ts"
     },
-    "./testing/__tests__/platform-services-fixture": {
-      "types": "./src/__tests__/support/platform-services-fixture.ts",
-      "default": "./src/__tests__/support/platform-services-fixture.ts"
-    },
     "./testing/__tests__/request-router-dispatch-mocks": {
       "types": "./src/__tests__/support/request-router-dispatch-mocks.ts",
       "default": "./src/__tests__/support/request-router-dispatch-mocks.ts"
@@ -156,22 +148,10 @@
       "types": "./src/core/gesture-runtime.ts",
       "default": "./src/core/gesture-runtime.ts"
     },
-    "./testing/handlers/__tests__/*": {
-      "types": "./src/__tests__/support/handlers/*.ts",
-      "default": "./src/__tests__/support/handlers/*.ts"
-    },
-    "./testing/handlers/lease": {
-      "types": "./src/sessions/handlers/lease.ts",
-      "default": "./src/sessions/handlers/lease.ts"
-    },
     "./testing/handlers/session-app-deployment": {
       "types": "./src/sessions/handlers/session-app-deployment.ts",
       "default": "./src/sessions/handlers/session-app-deployment.ts"
     },
-    "./testing/handlers/session-appstate": {
-      "types": "./src/sessions/handlers/session-appstate.ts",
-      "default": "./src/sessions/handlers/session-appstate.ts"
-    },
     "./testing/handlers/snapshot": {
       "types": "./src/sessions/handlers/snapshot.ts",
       "default": "./src/sessions/handlers/snapshot.ts"
@@ -284,10 +264,6 @@
       "types": "./src/server/http/http-server.ts",
       "default": "./src/server/http/http-server.ts"
     },
-    "./testing/server/transport": {
-      "types": "./src/server/http/transport.ts",
-      "default": "./src/server/http/transport.ts"
-    },
     "./testing/session-action-recorder": {
       "types": "./src/core/session-action-recorder.ts",
       "default": "./src/core/session-action-recorder.ts"
@@ -304,10 +280,6 @@
       "types": "./src/core/session-recovery-hints.ts",
       "default": "./src/core/session-recovery-hints.ts"
     },
-    "./testing/session-runtime": {
-      "types": "./src/sessions/session-runtime.ts",
-      "default": "./src/sessions/session-runtime.ts"
-    },
     "./testing/session-snapshot": {
       "types": "./src/execution/session-snapshot.ts",
       "default": "./src/execution/session-snapshot.ts"

packages/daemon/src/core/session-action-recorder-admission.test.ts

@@ -0,0 +1,46 @@
+import assert from 'node:assert/strict';
+import { test, vi } from 'vitest';
+import { getFlagDefinitionsForKey } from '@agent-device/command-registry/flag-registry';
+import type { FlagDefinition } from '@agent-device/command-registry/flag-types';
+import { makeIosSession } from '../__tests__/support/session-factories.ts';
+import { recordActionEntry } from './session-action-recorder.ts';
+
+test('recorder sanitization follows the declaration: an undeclared key is dropped, a planted declaration is recorded', async () => {
+  assert.equal(declarationFor('overlayRefs').recorded, false);
+  const shipped = recordActionEntry(makeIosSession('default'), {
+    command: 'screenshot',
+    positionals: [],
+    flags: { overlayRefs: true, fps: 5 },
+    result: {},
+  });
+  assert.equal(shipped?.flags.overlayRefs, undefined, 'overlayRefs is undeclared for recording');
+  assert.equal(shipped?.flags.fps, 5, 'fps is declared for recording');
+
+  vi.resetModules();
+  const registry = await import('@agent-device/command-registry/flag-registry');
+  const planted = declarationForIn(registry, 'overlayRefs');
+  Object.assign(planted, { recorded: true });
+  const { recordActionEntry: recordPlanted } = await import('./session-action-recorder.ts');
+  const recorded = recordPlanted(makeIosSession('default'), {
+    command: 'screenshot',
+    positionals: [],
+    flags: { overlayRefs: true },
+    result: {},
+  });
+  assert.equal(recorded?.flags.overlayRefs, true, 'a planted declaration is copied');
+});
+
+function declarationFor(key: 'overlayRefs'): FlagDefinition {
+  const declaration = getFlagDefinitionsForKey(key)[0];
+  assert.ok(declaration, `expected a declaration for ${key}`);
+  return declaration;
+}
+
+function declarationForIn(
+  registry: typeof import('@agent-device/command-registry/flag-registry'),
+  key: 'overlayRefs',
+): FlagDefinition {
+  const declaration = registry.getFlagDefinitionsForKey(key)[0];
+  assert.ok(declaration, `expected a declaration for ${key}`);
+  return declaration;
+}

packages/daemon/src/sessions/handlers/__tests__/session-appstate-facts.test.ts

@@ -0,0 +1,67 @@
+import { test, expect } from 'vitest';
+import * as path from 'node:path';
+import type { DeviceInfo } from '@agent-device/kernel/device';
+import { providerRuntimeOwner } from '@agent-device/contracts/platform-runtime';
+import { createUnavailableRuntimeFactsForTest, mkdtempForTestSync } from '@agent-device/test-kit';
+import { daemonPlatformServicesFixture } from '../../../__tests__/support/platform-services-fixture.ts';
+import {
+  handleSessionCommands,
+  mockBindDeviceRuntime,
+  mockInspectDeviceRuntimeFacts,
+} from '../../../__tests__/support/handlers/session-command-harness.ts';
+import {
+  makeSessionStore,
+  noopInvoke,
+} from '../../../__tests__/support/handlers/session-test-harness.ts';
+import { makeSession } from '../../../__tests__/support/session-factories.ts';
+
+test('appstate refuses unavailable provider facts before binding the device', async () => {
+  const staleDevice: DeviceInfo = {
+    platform: 'android',
+    id: 'limrun:android:released-lease',
+    name: 'Released Limrun Android',
+    kind: 'emulator',
+    target: 'mobile',
+    booted: true,
+  };
+  const unavailable = createUnavailableRuntimeFactsForTest(
+    staleDevice,
+    providerRuntimeOwner('limrun', 'stale'),
+    {
+      available: false,
+      reason: 'unsupported-provider-mode',
+      hint: 'Limrun requires a matching live provider session for this device.',
+    },
+  );
+  mockInspectDeviceRuntimeFacts.mockResolvedValue(unavailable);
+  const sessionStore = makeSessionStore();
+  sessionStore.publish('default', makeSession('default', { device: staleDevice }));
+
+  const response = await handleSessionCommands({
+    createCommandSurface: async () => {
+      throw new Error('appstate must refuse before loading a command surface');
+    },
+    platformServices: daemonPlatformServicesFixture(),
+    req: {
+      token: 't',
+      session: 'default',
+      command: 'appstate',
+      positionals: [],
+      flags: { platform: 'android' },
+    },
+    sessionName: 'default',
+    logPath: path.join(mkdtempForTestSync('daemon-appstate-facts-'), 'daemon.log'),
+    sessionStore,
+    invoke: noopInvoke,
+  });
+
+  expect(response?.ok).toBe(false);
+  if (response && !response.ok) {
+    expect(response.error.code).toBe('UNSUPPORTED_OPERATION');
+    expect(response.error.hint).toBe(
+      'Limrun requires a matching live provider session for this device.',
+    );
+  }
+  expect(mockInspectDeviceRuntimeFacts).toHaveBeenCalledOnce();
+  expect(mockBindDeviceRuntime).not.toHaveBeenCalled();
+});