Repository navigation
refactor(remote): extract src/remote into @agent-device/remote - #3711
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 83 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
3e23fbf to
45f85df
Compare
|
Size Report
Startup median (7 runs, lower is better):
|
|
This PR looks ready for review at 45f85df. The move reads as a pure extraction, and all 39 checks pass, with the size report at +61 B installed. Not blocking: the stderr capture in packages/remote/src/tests/upload-progress.test.ts (https://github.com/callstack/agent-device/blob/45f85df/packages/remote/src/__tests__/upload-progress.test.ts#L8) is a hand rewrite of withCapturedStderr, so you could later move stream-capture.ts into @agent-device/test-kit and import it from both sides, and 'remote' could move from TARGET_DAG_RANK to UNRANKED_ZONES in scripts/layering/model.ts (https://github.com/callstack/agent-device/blob/45f85df/scripts/layering/model.ts#L69), as #3706 did for react-native. Take or leave both. I did not run the build, typecheck or layering gates locally, and I did not inspect the built dist for the sdk-remote-config chunk. I relied on the green CI and your check:affected run. No conflicts. Nothing else blocks it. The Cubic thread on the sdk-remote-config regexes in tsdown.config.ts no longer applies, because the regexes now match packages/remote/src/remote-config-schema, so please resolve it: #3711 (comment) |
45f85df to
5fde231
Compare
Summary
Moves
src/remote(11 production files, 9 tests) into the private@agent-device/remotepackage with 6 narrow production exports. No behavior change, no root shims. Publicagent-device/remote-configis unchanged; thesdk-remote-configtsdown chunk patterns follow the move.Rebased onto
9ca333d5fb(plugins #3712).RemoteConfigProfilestays declared only in@agent-device/contracts;packages/plugins/src/connection.tskeeps its contracts import, so there is no plugins→remote dependency. 83 files, +250/−145.Validation
Tested commit:
5fde2314e2(base9ca333d5fb), clean worktree, pnpm 11.17.0 (the pinnedpackageManager).pnpm install --frozen-lockfile,pnpm build: exit 0.pnpm check:affected --run --head 5fde2314e2,AGENT_DEVICE_VITEST_MAX_WORKERS=1, fail-open full selection (63 checks): 36 passed, 2 deduplicated, 25 skipped as GitHub-authoritative or parked. Exit 0, receiptexactCommit: true.stream-capture.tsthrough test-kit, and dropping the pre-existingremote-config.tsre-export.Limits: unit and gate evidence only. CI owns coverage, provider integration and native lanes for this head.