Repository navigation
refactor(capture-kit): move screenshot-diff beside its pixel worker and overlays - #3710
Merged
Merged
Conversation
…nd overlays Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…it exports Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
I reviewed 05c6645 and found no problems. The move of screenshot-diff beside its pixel worker and overlays keeps the same logic and only updates import paths, and the code looks good. Smoke Tests is still running, so CI has not finished. The diff only moves a CLI-side diff-report module, so a failure there would be unlikely to come from this change. The only overlap is with the screenshot-diff CLI route. I did not run the eager-closure ceiling gate, fallow, or the test suite, and I did not check whether any consumer besides the three listed sees a changed import closure. This can merge once Smoke Tests finishes green. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the seven
src/screenshot-diff/modules (961 LOC) and their test intopackages/capture-kit/src/, next toscreenshot-diff-pixels, the PNG worker and the screenshot overlays they already depended on. Every outgoing edge already targeted kernel/capture-kit, so no new package or dependency is needed. Thescreenshot-difflayering zone is removed.src/cli/commands/screenshot.ts,src/commands/capture/runtime/diff-screenshot.ts,src/commands/output/diff.ts) now import@agent-device/capture-kit/screenshot-diff,/screenshot-diff-regionsand/screenshot-diff-overlay-matches.tmp-dir.fixtures.ts(capture-kit cannot depend on test-kit, which depends on it).Validation
Tested at
05c664543:pnpm check:affected --runpassed (layering, production-exports, package).vitest run packages/capture-kit/src/screenshot-diff.test.ts: 22/22.git diff -M90%shows renames with only import-specifier edits.Not run: device lanes (no runtime path change). CI pending.