refactor(test-kit): move the interaction-targeting node fixtures out of selectors

packages/replay-port/src/daemon-port/__tests__/target-classification.test.ts

@@ -9,14 +9,12 @@ import { readNodeLocalIdentity } from '@agent-device/ad-script';
 import { makeSnapshotState } from '@agent-device/selectors/snapshot-geometry-fixtures';
 import { classifyReplayTarget } from '../target-classification.ts';
 import { resolveElementReportedTwice } from '@agent-device/selectors/interaction-targeting';
-import {
-  ELEMENT14_DISTINCT_SUBTREE_NODES,
-  UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
-} from '@agent-device/selectors/interaction-targeting-fixtures';
 import {
   bottomTabsRealCaptureFixture,
-  recordArticleEvidence,
   buildNodes,
+  ELEMENT14_DISTINCT_SUBTREE_NODES,
+  recordArticleEvidence,
+  UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
 } from '@agent-device/test-kit';
 
 /** Verified outcomes carry the verified member + matchCount (for the post-resolution guard). */

packages/selectors/package.json

@@ -4,7 +4,7 @@
   "private": true,
   "sideEffects": false,
   "type": "module",
-  "description": "Shared selector matching, argument, and replay semantics for agent-device. `.` is string-only; `./ast` is the published parser surface behind `agent-device/selectors`; `./engine` is the resolve/list surface reserved for the selector-pipeline owner (R19); `./parameterized-recorded-fill` parameterizes recorded fill payloads against their selectors; the interaction-resolution subpaths (`./selector-pipeline`, `./interaction-targeting`, `./interaction-touch-point`, `./press-retarget`, `./absence-observation*`, \u2026) host the engine execution surface owned by the pipeline; `./snapshot-geometry-fixtures` is the canonical home for the geometry/touch-point test fixtures this package and root tests both build on (it re-exports `makeSnapshotState` from `@agent-device/capture-kit/snapshot-state-fixtures`, its own canonical home).",
+  "description": "Shared selector matching, argument, and replay semantics for agent-device. `.` is string-only; `./ast` is the published parser surface behind `agent-device/selectors`; `./engine` is the resolve/list surface reserved for the selector-pipeline owner (R19); `./parameterized-recorded-fill` parameterizes recorded fill payloads against their selectors; the interaction-resolution subpaths (`./selector-pipeline`, `./interaction-targeting`, `./interaction-touch-point`, `./press-retarget`, `./absence-observation*`, …) host the engine execution surface owned by the pipeline; `./snapshot-geometry-fixtures` is the canonical home for the geometry/touch-point test fixtures this package and root tests both build on (it re-exports `makeSnapshotState` from `@agent-device/capture-kit/snapshot-state-fixtures`, its own canonical home).",
   "dependencies": {
     "@agent-device/ad-script": "workspace:*",
     "@agent-device/capture-kit": "workspace:*",
@@ -52,10 +52,6 @@
       "types": "./src/interaction-targeting.ts",
       "default": "./src/interaction-targeting.ts"
     },
-    "./interaction-targeting-fixtures": {
-      "types": "./src/interaction-targeting.fixtures.ts",
-      "default": "./src/interaction-targeting.fixtures.ts"
-    },
     "./interaction-touch-point": {
       "types": "./src/interaction-touch-point.ts",
       "default": "./src/interaction-touch-point.ts"
@@ -86,6 +82,7 @@
     }
   },
   "devDependencies": {
+    "@agent-device/test-kit": "workspace:*",
     "fast-check": "^4.9.0"
   }
 }

packages/selectors/src/interaction-targeting.test.ts

@@ -20,7 +20,7 @@ import {
   INDEXED_PARITY_POLICY_NODES,
   TWO_ACTIONABLE_WRAPPER_CHAIN_NODES,
   UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
-} from './interaction-targeting.fixtures.ts';
+} from '@agent-device/test-kit';
 
 test('collapses one same-label wrapper chain to its shared actionable node', () => {
   const snapshot = makeSnapshotState(EQUIVALENT_WRAPPER_CHAIN_NODES);

packages/selectors/src/selector-pipeline.test.ts

@@ -15,7 +15,7 @@ import {
   RN_TEXT_ECHO_OFFSET_RECT_NODES,
   TWO_ACTIONABLE_WRAPPER_CHAIN_NODES,
   UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
-} from './interaction-targeting.fixtures.ts';
+} from '@agent-device/test-kit';
 import {
   listSelectorPipelineMatches,
   resolveActionSelectorPipeline,

packages/selectors/tsconfig.json

@@ -14,6 +14,7 @@
     { "path": "../ad-script" },
     { "path": "../capture-kit" },
     { "path": "../contracts" },
-    { "path": "../kernel" }
+    { "path": "../kernel" },
+    { "path": "../test-kit" }
   ]
 }

packages/test-kit/src/index.ts

@@ -51,6 +51,17 @@ export {
   withMockedPlatform,
 } from './host-execution.ts';
 export { pinOwnProcessStartTime } from './host-process-mock.ts';
+export {
+  ELEMENT14_DISTINCT_SUBTREE_NODES,
+  EQUIVALENT_WRAPPER_CHAIN_NODES,
+  INDEXED_PARITY_POLICY_NODES,
+  RN_TEXT_ECHO_AUTHORED_CHILD_NODES,
+  RN_TEXT_ECHO_DISTINCT_SUBTREE_NODES,
+  RN_TEXT_ECHO_NODES,
+  RN_TEXT_ECHO_OFFSET_RECT_NODES,
+  TWO_ACTIONABLE_WRAPPER_CHAIN_NODES,
+  UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
+} from './interaction-targeting.fixtures.ts';
 export {
   closeLoopbackServer,
   listenOnLoopback,

scripts/layering/package-boundaries.test.ts

@@ -775,7 +775,6 @@ test('the real tree parses, declares, and passes R11', () => {
     '@agent-device/selectors/interaction-error',
     '@agent-device/selectors/interaction-positionals',
     '@agent-device/selectors/interaction-targeting',
-    '@agent-device/selectors/interaction-targeting-fixtures',
     '@agent-device/selectors/interaction-touch-point',
     '@agent-device/selectors/parameterized-recorded-fill',
     '@agent-device/selectors/press-retarget',

src/commands/interaction/runtime/__tests__/test-utils/index.ts

@@ -12,7 +12,7 @@ import {
   RN_TEXT_ECHO_NODES,
   RN_TEXT_ECHO_OFFSET_RECT_NODES,
   UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
-} from '@agent-device/selectors/interaction-targeting-fixtures';
+} from '@agent-device/test-kit';
 import { createMemorySessionStore } from '../../../../../command-runtime/runtime-factory.ts';
 
 export function selectorSnapshot(): SnapshotState {

src/commands/interaction/runtime/selector-action-resolution.test.ts

@@ -5,7 +5,7 @@ import {
   ELEMENT14_DISTINCT_SUBTREE_NODES,
   EQUIVALENT_WRAPPER_CHAIN_NODES,
   UNVERIFIED_HITTABILITY_WRAPPER_CHAIN_NODES,
-} from '@agent-device/selectors/interaction-targeting-fixtures';
+} from '@agent-device/test-kit';
 import { SELECTOR_PIPELINE_POLICIES } from '@agent-device/selectors/selector-pipeline-policy';
 import { resolveActionSelector } from './selector-action-resolution.ts';