Skip to content

refactor(snapshot): move text-surface into snapshot presentation - #2152

Open
thymikee wants to merge 1 commit into
mainfrom
refactor/snapshot-text-surface-2133
Open

refactor(snapshot): move text-surface into snapshot presentation#2152
thymikee wants to merge 1 commit into
mainfrom
refactor/snapshot-text-surface-2133

Conversation

@thymikee

@thymikee thymikee commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

Move the snapshot text-surface policy and its test from src/utils into the existing src/snapshot/snapshot-presentation owner.

Update the three production importers and move the path-keyed Fallow baseline entry. The production module is byte-identical and no runtime behavior changes.

Closes #2133

Validation

  • pnpm vitest run src/snapshot/snapshot-presentation/text-surface.test.ts
  • pnpm vitest run src/commands/interaction/runtime/selector-read.test.ts src/daemon/handlers/__tests__/interaction-read.test.ts
  • node --experimental-strip-types --test scripts/layering/snapshot-presentation-boundary.test.ts
  • pnpm format
  • pnpm check:affected --run — all runnable checks passed; native, device, coverage, and other GitHub-authoritative lanes remain for CI.
  • Independent adversarial review: READY, no code-level blockers.

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.51 MB 2.51 MB 0 B
JS gzip 841.4 kB 841.4 kB 0 B
npm tarball 968.2 kB 968.2 kB 0 B
npm unpacked 3.35 MB 3.35 MB 0 B

npm unpacked components

Component Base Current Diff
JS / dist source 2.67 MB 2.67 MB 0 B
Apple runner source/project 581.1 kB 581.1 kB 0 B
macOS helper source 54.8 kB 54.8 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 45.6 kB 45.6 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 31.3 ms 32.2 ms +0.9 ms
CLI --help 82.1 ms 83.0 ms +1.0 ms

Top changed chunks: no changes in the largest emitted chunks.

Top changed packed files

No changed packed files.

@thymikee

Copy link
Copy Markdown
Member Author

Review found no code or ownership-design issues. This is the intended smallest #2129 child: the byte-identical text-surface policy and its test move into ADR 0004's existing snapshot-presentation owner, the three declared consumers follow it, and no utils shim or public surface remains. The existing snapshot-facet boundary test continues to provide the named positive control. Exact-head CI, native Smoke, Coverage, Repo Guards, and Size are all green.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(snapshot): move text-surface policy into snapshot-presentation

1 participant