test: characterize replay application behavior and coordinator ownership - #2137
Open
thymikee wants to merge 1 commit into
Open
test: characterize replay application behavior and coordinator ownership#2137thymikee wants to merge 1 commit into
thymikee wants to merge 1 commit into
Conversation
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed filesNo changed packed files. |
Member
Author
|
Review found no code or characterization-design issues. The new suite asserts application behavior at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one representative application-boundary contract through
handleSessionReplayCommandsfor native and Maestro replay/test flows. It covers admission-before-mutation, routing, session lifetime, failure projection and artifacts, format-neutral suite hosting, progress, and cancellation. The existing AST/import coordinator-ownership proof remains unchanged; no production files or exports changed.Closes #2130
Validation
pnpm check:affected --run: all runnable checks passed (format, lint, typecheck, fallow, related Vitest).createReplayCoordinatorimport failed both ownership tests; aSessionStoreimport in the resume chain failed the named no-binding test.Scope / size
Residual risks