fix: derive interaction wire projection#1149
Open
thymikee wants to merge 1 commit into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
c6347bf to
555ee94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derive interaction wire echo fields from command metadata instead of filtering backend fields in the response builder.
Move Apple runner diagnostic stripping to a runner-owned projection so touch response construction only composes already-projected wire data.
Validation
pnpm --pm-on-fail=ignore format
pnpm --pm-on-fail=ignore typecheck
pnpm --pm-on-fail=ignore lint
pnpm --pm-on-fail=ignore exec vitest run src/commands/interaction/metadata.test.ts src/platforms/apple/core/tests/runner-result-projection.test.ts src/daemon/handlers/tests/interaction.test.ts src/mcp/tests/command-tools.test.ts src/commands/interaction/runtime/interactions.test.ts --project unit-core
pnpm --pm-on-fail=ignore exec vitest run --project interaction-contract test/integration/interaction-contract/interaction-response-shape.contract.test.ts test/integration/interaction-contract/direct-ios-selector.contract.test.ts
pnpm --pm-on-fail=ignore test:integration:provider
pnpm --pm-on-fail=ignore test:coverage
pnpm --pm-on-fail=ignore build
pnpm --pm-on-fail=ignore check:fallow --base origin/main