fix: soften recovered snapshot warning#1146
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Reviewed the focused snapshot-quality diff. The change only softens the human warning text for recovered snapshots; the structured verdict and low-level recovery reason still remain available through snapshotQuality in JSON. The updated tests cover both runtime rendering and the canonical warning formatter, and all checks are green. No blockers found. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Soften recovered snapshot warnings so successful private-AX recovery reads as safe to continue instead of surfacing raw XCTest failure details by default.
Keep the low-level recovery reason available through JSON as
snapshotQuality.reason, and make depth-cap guidance conditional on needing deeper content.Validation
node ./node_modules/oxfmt/bin/oxfmt --check src/snapshot/snapshot-quality.ts src/utils/__tests__/snapshot-quality.test.ts src/commands/capture/runtime/snapshot.test.tspnpm exec vitest run src/utils/__tests__/snapshot-quality.test.ts src/commands/capture/runtime/snapshot.test.ts./node_modules/.bin/tsgo -p tsconfig.json