fix: recover Android recordings after daemon restart#1129
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This was referenced Jul 6, 2026
Member
Author
|
Ready for human review. Review pass on #1129:
Residual risk: this is the narrow recovery fix for #1117. Durable chunk/session ownership hardening is intentionally stacked in #1131 / #1130, so it should follow this PR rather than block it. |
bed0802 to
bc2bd44
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1117 by recovering Android screenrecord when daemon recording state is lost before record stop.
Adds device-side recovery metadata plus a bounded process-scan fallback so a fresh daemon can stop, pull, and clean the orphaned recording instead of returning no active recording.
Validation
Attempted pnpm check:unit and pnpm test:coverage; both hit unrelated host-load/platform flakes, and the failing files/groups passed when rerun in isolation.