Repository navigation
Delete process_task pass-through wrapper - #50
Merged
Merged
Conversation
process_task added no behavior over execute_task; build_context now calls execute_task directly, matching the pattern of the deletion test in the issue.
Contributor
|
Version hint: minor Comment ID: Display version hint-auto-generated |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_task, a pure pass-through wrapper aroundexecute_taskthat added no behavior or invariant of its own.build_contextnow callsexecute_taskdirectly in thecase Task():branch, matching the deletion test proposed in the issue.test_context.pymocks fromprocess_tasktoexecute_taskaccordingly.Closes #43
Test plan
uv run pytest --agent-digest=term -p no:sugar— full suite passes (328 tests)uv run ruff checkon changed filesprocess_task/context_builder.tasksreferences — none foundNote
Code review during this PR surfaced a pre-existing, unrelated dead test (
initial_context_merges_with_extra_contextmissing itstest_prefix, so pytest never runs it). Filed as #49 rather than fixed here, to keep this PR scoped to #43.