feat(cli): mops generate bindings for .did → Motoko - #641
Open
Kamirus wants to merge 4 commits into
Open
Conversation
Embed candid_parser's Motoko bindgen in the CLI wasm so projects can regenerate service types for runtime-chosen principals without installing didc. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 1df8e29 |
Reject .did imports, allow ad-hoc without mops.toml, tighten path detection and errors, and cover those paths in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motoko projects that call many principals sharing one interface (ICRC ledgers, routers, wallets) need typed
actor(id) : Foo.Selfwithout hand-writing service modules or installingdidc.mops generate bindingsembedscandid_parser's Motoko bindgen (same codegen asdidc bind -t mo) in the existing CLI wasm and regenerates.mofrom committed.didfiles.Before
After
mops generate bindings # or ad-hoc (mops.toml optional): mops generate bindings candid/icrc.did -o bindings/ICRC.moWhat is unchanged
mops generate candid(Motoko →.did) is untouched.canister:+--actor-env-alias(examples#1452 / #1453).build/checkin v1 — explicit only..didimports are rejected (flatten first). Unlikedidc, we do not resolve imports via the filesystem.Context: dfinity/examples#1454.