Repository navigation
Preparar la publicación en Maven Central - #2
Merged
Merged
Conversation
Agrega lo que Central exige y faltaba (developers, fuentes, javadoc y firma) en un perfil release, para que el build de siempre no cambie. El javadoc deja afuera el paquete internal. Se publica desde GitHub Actions al subir un tag vX.Y.Z y no desde Windows: el plugin de Sonatype arma el bundle en Windows con barras invertidas dentro del zip. autoPublish queda apagado, asi que cada version se revisa y se publica a mano desde el portal. docs/publicar.md tiene los pasos de una sola vez (token, GPG, secrets) y los de cada version.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented CLI setup omits two secrets required for releases.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prepares the Java SDK for controlled publication to Maven Central.
Changes:
- Adds release artifacts, GPG signing, and Sonatype publishing configuration.
- Adds a tag-driven release workflow with manual publication.
- Documents repository and per-release setup.
| File | Description |
|---|---|
pom.xml |
Configures Maven Central metadata and release plugins. |
.github/workflows/release.yml |
Builds, signs, and uploads tagged releases. |
docs/publicar.md |
Documents release setup and operation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+57
to
+58
| gh secret set CENTRAL_USERNAME --repo caerus-dev/caerus-sdk-java | ||
| gpg --armor --export-secret-keys ID_DE_LA_CLAVE | gh secret set GPG_PRIVATE_KEY --repo caerus-dev/caerus-sdk-java |
Contributor
Author
There was a problem hiding this comment.
Corregido: la guía ahora tiene el comando de cada uno de los cuatro secrets.
Faltaban CENTRAL_PASSWORD y GPG_PASSPHRASE: siguiendo la guia, la primera publicacion fallaba al autenticar o al firmar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deja el SDK listo para publicarse en Maven Central como
io.github.caerus-dev:caerus-sdk.releaseen elpom.xmlcon el jar de fuentes, el de javadoc (sin el paqueteinternal), la firma GPG y el plugin de publicación de Sonatype. El build de siempre no cambia.developers,developerConnectioneissueManagement, que Central exige.release.yml: al subir un tagvX.Y.Ztoma la versión del tag, corre los tests, firma y sube a Central.autoPublishqueda apagado, así que cada versión se revisa y se publica a mano desde el portal.docs/publicar.mdcon los pasos de una sola vez (token, GPG, secrets) y los de cada versión.Se publica desde CI y no desde una máquina Windows: ahí el plugin arma el zip con
\como separador de rutas.Verificado
0.1.0, el bundle trae.pom, jar, fuentes, javadoc y checksums. La firma se salteó en esta prueba.dev.caerus.sdk,.sre,.dlsy.webhooks.io.github.caerus-devestá verificado en Central.La firma y la subida reales se prueban con el primer tag.