Repository navigation
Conversation
jnk0
changed the title
The incident and schedule components used __('Affected Components')
and a hardcoded ' and ' when listing components. The package ships no
JSON translations, so both stayed English in every locale.
Use the existing incident.affected_components_header key and add a
cachet.and key for the conjunction.
The reported label on the status page and several dashboard labels
used plain strings such as __('Reported') or fixed English text. The
package ships no JSON translations, so they stayed English in every
locale.
Use existing package keys where available and add an update language
file for the updates relation manager shared by incidents and
schedules, plus a metric suffix placeholder key.
jnk0
force-pushed
the
fix-affected-components-label
branch
from
November 11, 2026 13:19
d2f5e36 to
7da1f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incident and schedule components used __('Affected Components') and a hardcoded ' and ' when listing components. The package ships no JSON translations, so both stayed English in every locale.
Use the existing incident.affected_components_header key and add a cachet.and key for the conjunction.
Also translate the remaining hardcoded labels: the "Reported" entry on the status page, the updates and components relation managers in the dashboard, the incident user field and the metric suffix placeholder.