Repository navigation
Show the component group status in the system status view - #503
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484.
With "Display system status" on, the status page uses the system status list, and its group rows ignore "Show component group status": a collapsed group always shows a green check, even when one of its components has a major outage.
The group row now uses the group's worst component status, with the same icon and colour the component rows use, when the setting is on. With the setting off it shows no status icon, like the other status page view.
Tests in StatusPageTest: a group with a major outage component, with the setting on and off. Both fail on main. Full suite: same 2 failures as main (the two SVG badge tests), everything else passes.