Skip to content

Cranelift: construct all-zero vectors with vconst - #14084

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
myunbin:add-zero-vec-helper
Aug 7, 2026
Merged

Cranelift: construct all-zero vectors with vconst#14084
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
myunbin:add-zero-vec-helper

Conversation

@myunbin

@myunbin myunbin commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Add a mid-end helper that creates a zero-filled ir::Constant.

Follow-up to #13850

@myunbin
myunbin requested a review from a team as a code owner August 6, 2026 08:58
@myunbin
myunbin requested review from alexcrichton and removed request for a team August 6, 2026 08:58
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Subscribe to Label Action

cc @cfallin, @fitzgen

Details This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton

Copy link
Copy Markdown
Member

lgtm, thanks! I think there's some more test cases to update though from CI

@myunbin
myunbin force-pushed the add-zero-vec-helper branch from bfde302 to e796f6a Compare August 7, 2026 00:34
@myunbin
myunbin requested a review from a team as a code owner August 7, 2026 00:34
@myunbin
myunbin force-pushed the add-zero-vec-helper branch from e796f6a to e5a165d Compare August 7, 2026 00:38
@myunbin

myunbin commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@alexcrichton Test cases updated. Thanks!

@alexcrichton
alexcrichton enabled auto-merge August 7, 2026 16:34
@alexcrichton
alexcrichton added this pull request to the merge queue Aug 7, 2026
Merged via the queue into bytecodealliance:main with commit d2c2b92 Aug 7, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants