Fix alias region used when initializing passive segments#13823
Merged
Conversation
This commit fixes a minor mistake to use the right alias region when initializing a passive element segment during startup. This requires using a slightly different helper than was previously done for GC references because the element segment lives in a different region than the default GC heap.
fitzgen
approved these changes
Jul 6, 2026
fitzgen
left a comment
fitzgen
left a comment
Member
There was a problem hiding this comment.
I'll wrap this up into a backport for the unreleased release branch, along with the assertion that we always tag everything with an alias region.
alexcrichton
added a commit
that referenced
this pull request
Jul 6, 2026
* Add an alias region for data segments (#13811) This also bumped the AliasRegionKey's kind bits up to 6, which triggered a mass renumbering in the disas tests. * Debug assert that all memory instructions have alias regions (#13825) We should never emit a load/store instruction that isn't tagged with an alias region. * Fix alias region used when initializing passive segments (#13823) This commit fixes a minor mistake to use the right alias region when initializing a passive element segment during startup. This requires using a slightly different helper than was previously done for GC references because the element segment lives in a different region than the default GC heap. --------- Co-authored-by: Alex Crichton <alex@alexcrichton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor mistake to use the right alias region when initializing a passive element segment during startup. This requires using a slightly different helper than was previously done for GC references because the element segment lives in a different region than the default GC heap.