Repository navigation
fix(p3-shim): restore task context for deferred fused adapter starts - #2261
Merged
vados-cosmonic merged 1 commit intoOct 15, 2026
Merged
vados-cosmonic merged 1 commit into
vados-cosmonic merged 1 commit into
Conversation
ryan-surname-p
requested review from
andreiltd and
vados-cosmonic
as code owners
October 14, 2026 18:07
ryan-surname-p
force-pushed
the
fix/p3-delayed-subtask-context
branch
from
October 14, 2026 18:16
3344706 to
12aaafe
Compare
vados-cosmonic
approved these changes
Oct 15, 2026
vados-cosmonic
left a comment
vados-cosmonic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀
Thanks for the fix @ryan-surname-p !
ryan-surname-p
changed the title
ryan-surname-p
force-pushed
the
fix/p3-delayed-subtask-context
branch
from
October 15, 2026 14:09
12aaafe to
e21ac9e
Compare
vados-cosmonic
enabled auto-merge
October 15, 2026 14:13
Collaborator
|
Thanks for the proactive rebase! This should be in soon and I'll make a release of p3-shim then release jco as well |
vados-cosmonic
force-pushed
the
fix/p3-delayed-subtask-context
branch
from
October 15, 2026 14:44
e21ac9e to
aee49c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jco tracks the current component task using dynamically scoped global metadata. When a delayed path resumes in a new timer callback, that metadata has already been cleared.
The fix restores the callee’s task metadata while the delayed adapter runs, then reinstates the previous context.