Skip to content

fix: preview3 build ci #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vados-cosmonic merged 2 commits into from
Oct 14, 2026
Merged

fix: preview3 build ci #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a27d5e3
fix(p3-shim): compile browser imports with browser conditions
vados-cosmonic Oct 14, 2026
52c7531
ci: build shims and match their test packages explicitly
vados-cosmonic Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,11 +500,18 @@ jobs:
- name: Build jco
run: pnpm run build

- name: Build preview2-shim
run: pnpm --filter '@bytecodealliance/preview2-shim' --fail-if-no-match run build

- name: Build preview3-shim
if: ${{ matrix.workspace == 'preview3-shim' }}
run: pnpm --filter '@bytecodealliance/preview3-shim' --fail-if-no-match run build

- name: Test Workspaces
env:
TEST_PUPPETEER_LAUNCH_ARGS: |
--no-sandbox
run: pnpm --filter 'packages/${{ matrix.workspace }}' run test
run: pnpm --filter '@bytecodealliance/${{ matrix.workspace }}' --fail-if-no-match run test

test-jco-node-fs:
name: Test jco-node-fs (${{ matrix.os }})
Expand Down
1 change: 1 addition & 0 deletions packages/preview3-shim/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# TypeScript build outputs
/dist/
/*.tsbuildinfo
6 changes: 3 additions & 3 deletions packages/preview3-shim/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
}
},
"scripts": {
"build": "tsc --project tsconfig.build.json && node scripts/build-workers.mjs",
"build:watch": "tsc --watch",
"types:check": "tsc --noEmit",
"build": "tsc --project tsconfig.build.json && tsc --project tsconfig.build.browser.json && node scripts/build-workers.mjs",
"build:watch": "tsc --build --watch tsconfig.build.json tsconfig.build.browser.json",
"types:check": "tsc --noEmit && tsc --project tsconfig.browser.json --noEmit",
"fmt": "oxfmt",
"fmt:check": "oxfmt --check",
"lint": "oxlint",
Expand Down
8 changes: 8 additions & 0 deletions packages/preview3-shim/tsconfig.browser.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "./tsconfig.json",
"include": ["src/browser/**/*"],
"compilerOptions": {
"module": "ESNext",
"moduleResolution": "Bundler"
}
}
10 changes: 10 additions & 0 deletions packages/preview3-shim/tsconfig.build.browser.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.browser.json",
"compilerOptions": {
"rootDir": "src/",
"declaration": true,
"declarationMap": false,
"sourceMap": false,
"noEmit": false
}
}
2 changes: 1 addition & 1 deletion packages/preview3-shim/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"include": ["src/**/*"],
"include": ["src/nodejs/**/*"],
"compilerOptions": {
"outDir": "dist",
"target": "ES2022",
Expand Down
Loading