Skip to content

Fix handling registry image 404 - #2691

Merged
oliversun9 merged 3 commits into
mainfrom
osun/fix-404-handling
Aug 27, 2026
Merged

Fix handling registry image 404#2691
oliversun9 merged 3 commits into
mainfrom
osun/fix-404-handling

Conversation

@oliversun9

@oliversun9 oliversun9 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The caller of the modified function:

	registryImage, imageID, err := fetchRegistryImageAndImageID(p)
	if err != nil {
		return release.PluginRelease{}, false, err
	}
	if registryImage == "" || imageID == "" {
		c.logger.InfoContext(ctx, "unable to detect registry image and image ID",
			slog.String("owner", identity.Owner()),
			slog.String("plugin", identity.Plugin()),
			slog.String("version", p.PluginVersion),
		)
		return release.PluginRelease{}, true, nil
	}

So we need fetchRegistryImageAndImageID to be able to return "", "", nil

@oliversun9
oliversun9 requested a review from pkwarren August 27, 2026 08:07
@pkwarren

Copy link
Copy Markdown
Member

This is a good fix however the underlying issue is that this CI workflow has been hung for ~22 hours: https://github.com/bufbuild/plugins/actions/runs/32984329655

Unfortunately it is unable to be canceled. We can merge this but I'm going to disable the release workflow until we can get a build going again.

Comment thread go.sum Outdated
@oliversun9
oliversun9 requested a review from pkwarren August 27, 2026 15:01
@oliversun9
oliversun9 merged commit b747d8e into main Aug 27, 2026
3 checks passed
@oliversun9
oliversun9 deleted the osun/fix-404-handling branch August 27, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants