Fix handling registry image 404 - #2691
Merged
Merged
Conversation
Member
|
This is a good fix however the underlying issue is that this CI workflow has been hung for ~22 hours: https://github.com/bufbuild/plugins/actions/runs/32984329655 Unfortunately it is unable to be canceled. We can merge this but I'm going to disable the release workflow until we can get a build going again. |
pkwarren
reviewed
Aug 27, 2026
pkwarren
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caller of the modified function:
So we need
fetchRegistryImageAndImageIDto be able to return"", "", nil