fix(logging): redact exception locals - #293
Merged
frostming merged 1 commit intoAug 25, 2026
Merged
Conversation
dagebot
approved these changes
Aug 25, 2026
dagebot
left a comment
Contributor
There was a problem hiding this comment.
Review: ✅ Looks good, approve
This is a solid security fix for #292. Loguru's default diagnose=True renders local variables in exception traces, which could leak provider API keys.
What I like
- Precise change —
diagnose=Falseon both sinks (stderr + Logfire), preserving traceback/error info while hiding local variable values. - Real issue — The security risk is genuine: exception logs could expose sensitive config like API keys.
- Good regression test — Monkeypatches
logger.addand asserts every Bub-owned sink explicitly disables diagnostics. Prevents future sinks from forgetting. - CI all green — quality, tests-and-type-check (3.12/3.13/3.14), check-docs all pass.
Minor note
The test monkeypatches the global logger.remove/logger.add. If future tests interact with loguru they might conflict, but no issue currently.
Conclusion: Direct merge. Simple, focused, with proper test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagnose=FalseThis preserves traceback/error reporting while preventing exception logs from rendering local secrets such as provider API keys.
Closes #292
Verification
make checkmake test(307 passed)git diff --check