Skip to content

fix: getBuildId & failedTestIds mcp tool #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SavioBS629 wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −2
Open

fix: getBuildId & failedTestIds mcp tool #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a37f4b
fix: getBuildId mcp tool
SavioBS629 Jun 19, 2026
442d468
fix: fixed failedTestIds
SavioBS629 Jun 19, 2026
35b9a51
Merge branch 'main' of github.com:SavioBS629/mcp-server into getBuild…
SavioBS629 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tools/rca-agent-utils/get-build-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export async function getBuildId(
);
url.searchParams.append("project_name", projectName);
url.searchParams.append("build_name", buildName);
url.searchParams.append("user_name", username);

const authHeader =
"Basic " + Buffer.from(`${username}:${accessKey}`).toString("base64");
Expand Down
2 changes: 1 addition & 1 deletion src/tools/rca-agent-utils/get-failed-test-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function extractFailedTestIds(
let failedTests: FailedTestInfo[] = [];

for (const node of hierarchy) {
if (node.details?.status === status && node.details?.run_count) {
if (node.details?.status === status) {

@SavioBS629 SavioBS629 Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Low] Behavioral change is untested

Dropping && node.details?.run_count is a plausible, intended fix (zero-run failed tests were being skipped), but extractFailedTestIds is non-exported and getTestIds is mocked in tests/tools/rcaAgent.test.ts, so neither the old nor new condition is ever exercised — no regression guard.

Suggestion: Export extractFailedTestIds (or drive via getTestIds with a mocked fetch + hierarchy fixture) and add cases: status match with run_count: 0, status match with missing details, and a non-matching status.

Reviewer: stack:code-review

if (node.details?.observability_url) {
const idMatch = node.details.observability_url.match(/details=(\d+)/);
if (idMatch) {
Expand Down