fix(workflow): preserve unresolved positional placeholders - #183
Open
mikamikasuki wants to merge 2 commits into
Open
mikamikasuki wants to merge 2 commits into
mikamikasuki wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow execution crashes on bare positional placeholders such as
{0}or{}because formatting receives only named context values. Preserve those strings through the existing unresolved-placeholder path while keeping named indexing and formatting errors visible. Input defaults retain their existing behavior. Regression tests run through both pytest and the file’s direct harness.Fixes #154
Validation:
uv run --frozen --with pytest --with pytest-asyncio python -m pytest --asyncio-mode=auto tests/test_workflow_execution.py -qanduv run --frozen --with pytest --with pytest-asyncio python tests/test_workflow_execution.pyeach pass 17 tests. Scopedruff checkandruff format --checkpass.