Skip to content

fix(workflow): preserve unresolved positional placeholders - #183

Open
mikamikasuki wants to merge 2 commits into
browser-use:mainfrom
mikamikasuki:codex/fix-workflow-154
Open

mikamikasuki wants to merge 2 commits into
browser-use:mainfrom
mikamikasuki:codex/fix-workflow-154

Conversation

@mikamikasuki

@mikamikasuki mikamikasuki commented Oct 3, 2026 •

Copy link
Copy Markdown

Workflow execution crashes on bare positional placeholders such as {0} or {} because formatting receives only named context values. Preserve those strings through the existing unresolved-placeholder path while keeping named indexing and formatting errors visible. Input defaults retain their existing behavior. Regression tests run through both pytest and the file’s direct harness.

Fixes #154

Validation: uv run --frozen --with pytest --with pytest-asyncio python -m pytest --asyncio-mode=auto tests/test_workflow_execution.py -q and uv run --frozen --with pytest --with pytest-asyncio python tests/test_workflow_execution.py each pass 17 tests. Scoped ruff check and ruff format --check pass.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread workflows/tests/test_workflow_execution.py Outdated
Comment thread workflows/workflow_use/workflow/service.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: _resolve_placeholders crashes with IndexError on positional format placeholders like {0}

1 participant