Allow Swedish postcodes above 984 99 - #24
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
============================================
- Coverage 99.21% 99.21% -0.01%
+ Complexity 504 502 -2
============================================
Files 186 186
Lines 1021 1019 -2
============================================
- Hits 1013 1011 -2
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thank you, @cx18121! |
Member
|
Released in 0.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swedish postcodes above 984 99 are currently rejected, even though they are in active use. For example, Kiruna municipality publishes addresses using both 985 31 Vittangi and 986 31 Karesuando:
https://kiruna.se/utbildning--barnomsorg/grundskola/grundskolor/vittangi-skola.html
This removes the stale upper allocation bound and validates the stable postcode structure instead: five digits beginning with a non-zero digit.
The existing
NNN NNformatting remains unchanged. Regression cases for98531and98631have been added to the existing Swedish formatter data provider.