Skip to content

uptake instancetypes APi#421

Open
patelspratik wants to merge 4 commits into
mainfrom
uptakeinstancetypes
Open

uptake instancetypes APi#421
patelspratik wants to merge 4 commits into
mainfrom
uptakeinstancetypes

Conversation

@patelspratik

@patelspratik patelspratik commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Move CLI instance catalogs to dev-plane and replace WorkspaceGroups with CloudCreds.

  • Migrated the authenticated organization catalog from brev-deploy REST to dev-plane InstanceService.ListOrganizationAvailableInstanceTypes.
  • Migrated public instance search from /v1/instance/types to unauthenticated dev-plane InstanceService.ListPublicInstanceType.
  • Updated create flows to select and submit cloudCredId directly.
  • Removed deprecated workspace-group models, fallbacks, request fields, labels, metadata, and SSH behavior.
  • Normalized Docker Compose launchables so fileUrl takes precedence over hydrated yamlString, matching the UI. This was exposed by a launchable that succeeded in the UI but failed from the CLI.

API Impact

The CLI no longer calls:

  • GET /api/instances/alltypesavailable/:organizationId
  • GET /v1/instance/types

Organization catalogs now use authenticated dev-plane ConnectRPC and include active cloud credentials plus dev-plane provider/cloud filtering. Public brev search remains unauthenticated but now calls InstanceService.ListPublicInstanceType directly.

The existing /v1/instance/types route remains available for older CLI versions and other consumers.

The CLI also no longer:

  • Sends X-Workspace-Group-ID on brev-deploy or proxy requests.
  • Sends workspaceGroupId in workspace create requests or launchable labels.
  • Uses workspace groups to resolve instance availability or cloud placement.

POST /api/organizations/:organizationId/workspaces remains in use for creation, but now receives cloudCredId as the placement identifier.

Workspace-Group Removal

  • Removed workspace-group compatibility types and catalog aliases.
  • Removed cloud-credential fallback through WorkspaceGroups.
  • Removed workspace-group fields from workspace entities, create options, launchable responses, and local workspace metadata.
  • Removed hardcoded legacy workspace-group detection.
  • Removed the legacy brev SSH user, /home/brev/workspace path, and automatically generated brev proxy SSH configuration.
  • Existing backend workspaceGroupId response fields are ignored.

@patelspratik patelspratik force-pushed the uptakeinstancetypes branch from a8d61ba to 44fc931 Compare July 2, 2026 21:17
@patelspratik patelspratik changed the title initial uptake uptake instancetypes APi Jul 7, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.21311% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.58%. Comparing base (83ace83) to head (3de768b).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/store/instancetypes.go 72.15% 19 Missing and 3 partials ⚠️
pkg/cmd/gpucreate/gpucreate.go 73.33% 7 Missing and 1 partial ⚠️
pkg/cmd/gpusearch/gpusearch.go 33.33% 4 Missing and 2 partials ⚠️
pkg/store/workspace.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   20.09%   22.58%   +2.49%     
==========================================
  Files         140      135       -5     
  Lines       18451    18587     +136     
==========================================
+ Hits         3707     4198     +491     
+ Misses      14328    13924     -404     
- Partials      416      465      +49     
Flag Coverage Δ
Linux 22.58% <67.21%> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@patelspratik patelspratik marked this pull request as ready for review July 8, 2026 23:55
@patelspratik patelspratik requested a review from a team as a code owner July 8, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant