Skip to content

Fix IndexError when splitting ANSI-only strings #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yousefissa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix IndexError when splitting ANSI-only strings #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions curtsies/formatstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ def width_aware_splitlines(self, columns: int) -> Iterator["FmtStr"]:
return self._width_aware_splitlines(columns)

def _width_aware_splitlines(self, columns: int) -> Iterator["FmtStr"]:
if not self.chunks:
return
splitter = self.chunks[0].splitter()
chunks_of_line = []
width_of_line = 0
Expand Down
31 changes: 31 additions & 0 deletions tests/test_fmtstr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,37 @@ def test_width_aware_splitlines(self) -> None:
with self.assertRaises(ValueError):
s.width_aware_splitlines(1)

def test_width_aware_splitlines_empty(self) -> None:
for s in (FmtStr(), fmtstr(""), fmtstr("\x1b[0m"), fmtstr("\x1b[34m")):
for columns in (2, 80):
with self.subTest(s=repr(s), columns=columns):
self.assertEqual(list(s.width_aware_splitlines(columns)), [])

def test_width_aware_splitlines_empty_narrow_columns(self) -> None:
for s in (FmtStr(), fmtstr(""), fmtstr("\x1b[0m"), fmtstr("\x1b[34m")):
for columns in (-1, 0, 1):
with self.subTest(s=repr(s), columns=columns):
with self.assertRaises(ValueError):
s.width_aware_splitlines(columns)

def test_width_aware_splitlines_colorized_log(self) -> None:
log = "\x1b[34mDEBUG \x1b[0mmessage\r\n\x1b[0m"
for columns, expected in (
(80, [blue("DEBUG ") + "message"]),
(8, [blue("DEBUG ") + "me", fmtstr("ssage")]),
):
with self.subTest(columns=columns):
lines = [
wrapped
for line in log.splitlines()
for wrapped in fmtstr(line).width_aware_splitlines(columns)
]
self.assertEqual(lines, expected)

def test_width_aware_splitlines_zero_width_text(self) -> None:
s = blue("\u0300")
self.assertEqual(list(s.width_aware_splitlines(2)), [s])

def test_width_at_offset(self) -> None:
self.assertEqual(fmtstr("abＥcdef").width_at_offset(0), 0)
self.assertEqual(fmtstr("abＥcdef").width_at_offset(2), 2)
Expand Down