feat: add modernizedDismissDelayMs prop for override#4698
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
ChangesModernized upload dismissal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: read ECONNRESET Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| isExpanded?: boolean; | ||
| onToggle?: (isExpanded: boolean) => void; | ||
| maxFileSize?: number; | ||
| modernizedDismissDelayMs?: number; |
There was a problem hiding this comment.
nit: it would be nice if these new props were added alphabetically into the existing list
| isExpanded?: boolean; | ||
| onToggle?: (isExpanded: boolean) => void; | ||
| maxFileSize?: number; | ||
| modernizedDismissDelayMs?: number; |
There was a problem hiding this comment.
nit: a better long term name would be to remove the "modernized" prefix. that way you don't need to change the name in the future once the modernized feature becomes the default behavior
Merge Queue Status
This pull request spent 9 seconds in the queue, including 1 second running CI. Required conditions to merge
|
Add prop for overriding timer
Summary by CodeRabbit
New Features
Bug Fixes