Skip to content

feat: add modernizedDismissDelayMs prop for override#4698

Merged
mergify[bot] merged 1 commit into
masterfrom
modernized-uploader-dismiss-delay
Jul 17, 2026
Merged

feat: add modernizedDismissDelayMs prop for override#4698
mergify[bot] merged 1 commit into
masterfrom
modernized-uploader-dismiss-delay

Conversation

@dealwith

@dealwith dealwith commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Add prop for overriding timer

Summary by CodeRabbit

  • New Features

    • Added an optional setting to customize how long the modernized uploads panel remains visible before dismissing.
  • Bug Fixes

    • Improved the uploads panel dismissal behavior to consistently honor the configured timing.

@dealwith
dealwith requested review from a team as code owners July 16, 2026 14:42
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f4aa9c59-afb0-4b85-bd69-5b42922fc13b

📥 Commits

Reviewing files that changed from the base of the PR and between c5e0f55 and 60039d2.

📒 Files selected for processing (2)
  • src/elements/content-uploader/ContentUploader.tsx
  • src/elements/content-uploader/__tests__/ContentUploader.test.js

Walkthrough

ContentUploader now accepts a configurable delay for dismissing the modernized uploads manager panel, defaults it to the existing delay, and tests the resulting shown to dismissing transition.

Changes

Modernized upload dismissal

Layer / File(s) Summary
Configurable dismissal delay and lifecycle coverage
src/elements/content-uploader/ContentUploader.tsx, src/elements/content-uploader/__tests__/ContentUploader.test.js
Adds modernizedDismissDelayMs with the existing delay as its default, uses it when scheduling dismissal, and tests the custom-delay transition. Includes a whitespace-only guard formatting adjustment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: ready-to-merge

Suggested reviewers: bkepka-box, olehrybak, tjuanitas

Poem

I’m a bunny watching timers hop,
A custom pause now tells them when to stop.
The panel stays shown, then fades away,
Tests keep the timing right each day.
Carrots cheer the clean delay! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a configurable modernizedDismissDelayMs override prop.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch modernized-uploader-dismiss-delay

Warning

Tools execution failed with the following error:

Failed to run tools: 14 UNAVAILABLE: read ECONNRESET


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dealwith dealwith self-assigned this Jul 17, 2026
isExpanded?: boolean;
onToggle?: (isExpanded: boolean) => void;
maxFileSize?: number;
modernizedDismissDelayMs?: number;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be nice if these new props were added alphabetically into the existing list

isExpanded?: boolean;
onToggle?: (isExpanded: boolean) => void;
maxFileSize?: number;
modernizedDismissDelayMs?: number;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a better long term name would be to remove the "modernized" prefix. that way you don't need to change the name in the future once the modernized feature becomes the default behavior

@mergify mergify Bot added the queued label Jul 17, 2026
@mergify

mergify Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-17 12:28 UTC · Rule: Automatic strict merge · triggered by rule Automatic merge queue
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-17 12:28 UTC · at 60039d2f1e14737f0126fe9a4e6335f9026e99d3 · squash

This pull request spent 9 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection] (documentation)
  • github-review-decision = APPROVED [🛡 GitHub branch protection] (documentation)
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@mergify
mergify Bot merged commit 18054d4 into master Jul 17, 2026
14 checks passed
@mergify
mergify Bot deleted the modernized-uploader-dismiss-delay branch July 17, 2026 12:28
@mergify mergify Bot removed the queued label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants