add Div_a_Grad_perp_FCI_unstructured by dschwoerer · Pull Request #3523 · boutproject/BOUT-dev

dschwoerer · 2026-10-27T13:13:26Z

Div_a_Grad_perp_FCI chooses automatically between structured and unstructured. This makes this completely automatic to calling code.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 42. Check the log or trigger a new build to see more.

github-actions · 2026-10-27T13:18:47Z

 #include "bout/output_bout_types.hxx" // NOLINT(unused-includes, misc-include-cleaner)
 #include "bout/region.hxx"
 #include "bout/vector2d.hxx"
+#if BOUT_HAS_PETSC


warning: no header providing "BOUT_HAS_PETSC" is directly included [misc-include-cleaner]

include/bout/fv_ops.hxx:8:

- #include "bout/field.hxx" + #include "bout/build_defines.hxx" + #include "bout/field.hxx"

github-actions · 2026-10-27T13:18:47Z

 #include "bout/vector2d.hxx"
+#if BOUT_HAS_PETSC
+#include <bout/petsclib.hxx>
+#include <petscmat.h>


warning: included header petsclib.hxx is not used directly [misc-include-cleaner]

Suggested change

#include <petscmat.h>

#include <petscmat.h>

github-actions · 2026-10-27T13:18:47Z

+  static std::shared_ptr<Div_a_Grad_perp_FCI> create(Mesh* mesh, BoutReal rho_s0);
+};
+
+class Div_a_Grad_perp_FCI_structured : public Div_a_Grad_perp_FCI {


warning: destructor of 'Div_a_Grad_perp_FCI_structured' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]

_s0); ^

Additional context

include/bout/fv_ops.hxx:224: make it public and virtual

_s0); ^

github-actions · 2026-10-27T13:18:47Z

  static std::map<Mesh*, std::weak_ptr<Div_a_Grad_perp_FCI>> op_cache;
 };

+class Div_a_Grad_perp_FCI_unstructured : public Div_a_Grad_perp_FCI {


warning: destructor of 'Div_a_Grad_perp_FCI_unstructured' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]

ache; ^

Additional context

include/bout/fv_ops.hxx:250: make it public and virtual

ache; ^

github-actions · 2026-10-27T13:18:47Z

 #include "bout/utils.hxx"
 #include <bout/yboundary_regions.hxx>
-
+#if BOUT_HAS_PETSC


warning: no header providing "BOUT_HAS_PETSC" is directly included [misc-include-cleaner]

src/mesh/fv_ops.cxx:1:

- #include "bout/fv_ops_impl.hxx" + #include "bout/build_defines.hxx" + #include "bout/fv_ops_impl.hxx"

github-actions · 2026-10-27T13:18:49Z

+  BOUT_DO_PETSC(MatCreateAIJ(BoutComm::get(), rowsplit.end - rowsplit.start,
+                             colsplit.end - colsplit.start, PETSC_DETERMINE,
+                             PETSC_DETERMINE, 0, d_nnz.data(), 0, o_nnz.data(), &mat));
+  PetscInt M, N;


warning: variable 'N' is not initialized [cppcoreguidelines-init-variables]

PetscInt M, N; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T13:18:49Z

+                             PETSC_DETERMINE, 0, d_nnz.data(), 0, o_nnz.data(), &mat));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(mat, &M, &N));
+  PetscInt m, n;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

PetscInt m, n;

PetscInt m;

PetscInt n;

github-actions · 2026-10-27T13:18:49Z

+                             PETSC_DETERMINE, 0, d_nnz.data(), 0, o_nnz.data(), &mat));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(mat, &M, &N));
+  PetscInt m, n;


warning: variable 'm' is not initialized [cppcoreguidelines-init-variables]

PetscInt m, n; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T13:18:49Z

+                             PETSC_DETERMINE, 0, d_nnz.data(), 0, o_nnz.data(), &mat));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(mat, &M, &N));
+  PetscInt m, n;


warning: variable 'n' is not initialized [cppcoreguidelines-init-variables]

PetscInt m, n; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T13:18:49Z

+  return mat;
+}
+void setVecFromField(Vec vec, Field3D f) {
+  auto mesh = f.getMesh();


warning: 'auto mesh' can be declared as 'auto *mesh' [readability-qualified-auto]

Suggested change

auto mesh = f.getMesh();

auto *mesh = f.getMesh();

github-actions

clang-tidy made some suggestions

github-actions · 2026-10-27T14:15:20Z

+  return dagp;
+}
+
+Div_a_Grad_perp_FCI_unstructured::Div_a_Grad_perp_FCI_unstructured(Mesh* mesh,


warning: constructor does not initialize these fields: inField, inA, vecGrad, vecInterp, multiplied, result [cppcoreguidelines-pro-type-member-init]

include/bout/fv_ops.hxx:267:

- inField; - Vec inA; - vecGrad; - ecInterp; - ltiplied; + inField{}; + Vec inA;{} + vecGrad; + ecIn{}terp; + ltiplied;{}{}

include/bout/fv_ops.hxx:273:

- t; + t{};

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecGrad));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecInterp));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

PetscInt M, N;

PetscInt M;

PetscInt N;

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecGrad));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecInterp));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;


warning: variable 'M' is not initialized [cppcoreguidelines-init-variables]

PetscInt M, N; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecGrad));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &vecInterp));
+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;


warning: variable 'N' is not initialized [cppcoreguidelines-init-variables]

PetscInt M, N; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(Div, &M, &N));
+  PetscInt m, n;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

PetscInt m, n;

PetscInt m;

PetscInt n;

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(Div, &M, &N));
+  PetscInt m, n;


warning: variable 'm' is not initialized [cppcoreguidelines-init-variables]

PetscInt m, n; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T14:15:20Z

+  BOUT_DO_PETSC(VecCreate(BoutComm::get(), &multiplied));
+  PetscInt M, N;
+  BOUT_DO_PETSC(MatGetSize(Div, &M, &N));
+  PetscInt m, n;


warning: variable 'n' is not initialized [cppcoreguidelines-init-variables]

PetscInt m, n; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2026-10-27T14:15:21Z

+  BOUT_DO_PETSC(MatGetSize(Div, &M, &N));
+  PetscInt m, n;
+  BOUT_DO_PETSC(MatGetLocalSize(Div, &m, &n));
+  for (auto vec : {inField, inA, result, vecGrad, vecInterp, multiplied}) {


warning: 'auto vec' can be declared as 'auto *vec' [readability-qualified-auto]

Suggested change

for (auto vec : {inField, inA, result, vecGrad, vecInterp, multiplied}) {

for (auto *vec : {inField, inA, result, vecGrad, vecInterp, multiplied}) {

add Div_a_Grad_perp_FCI_unstructured

3fdf5b1

Div_a_Grad_perp_FCI chooses automatically between structured and unstructured. This makes this completely automatic to calling code.

github-actions Bot reviewed Oct 27, 2026

View reviewed changes

dschwoerer added 2 commits October 27, 2026 14:26

Avoid warning on comparison

41a8aed

Ensure vars are set

4e80646

dschwoerer marked this pull request as draft October 27, 2026 13:38

Define PETScInt for non-petsc build

b503d2c

github-actions Bot reviewed Oct 27, 2026

View reviewed changes

	for (auto vec : {inField, inA, result, vecGrad, vecInterp, multiplied}) {
	for (auto *vec : {inField, inA, result, vecGrad, vecInterp, multiplied}) {

Conversation

dschwoerer commented Oct 27, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant